Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Ivy Frontend Test: numpy - linalg.scipy.linalg.norm #28205

Closed
wants to merge 0 commits into from

Conversation

rp097
Copy link
Contributor

@rp097 rp097 commented Feb 6, 2024

PR Description

The test was passing in a dtype (float16) to torch which is not actually supported by the torch’s native framework itself. I added that in the backend under unsupported dtypes. All test cases then passed.

Screenshot 2024-02-07 at 10 46 06 am

Related Issue

Closes #28197

Checklist

  • Did you add a function?
  • Did you add the tests?
  • Did you run your tests and are your tests passing?
  • Did pre-commit not fail on any check?
  • Did you follow the steps we provided?

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks

Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.

Issue Reference

In order to be considered for merging, the pull request description must refer to a specific issue number. This is described in our contributing guide and our PR template.
This check is looking for a phrase similar to: "Fixes #XYZ" or "Resolves #XYZ" where XYZ is the issue number that this PR is meant to address.

Conventional Commit PR Title

In order to be considered for merging, the pull request title must match the specification in conventional commits. You can edit the title in order for this check to pass.
Most often, our PR titles are something like one of these:

  • docs: correct typo in README
  • feat: implement dark mode"
  • fix: correct remove button behavior

Linting Errors

  • Found type "null", must be one of "feat","fix","docs","style","refactor","perf","test","build","ci","chore","revert"
  • No subject found

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on making your first Pull Request and thanks for supporting Ivy! 🎉
Join the conversation in our Discord.

For every PR opened, we run unit tests and comment the results in the PR to ensure the functionality remains intact.
Please make sure they are passing. 💪

If you want to check them from the action runners, you can open the display_test_results job. 👀
It contains the following two sections:

  • Combined Test Results: This shows the results of all the ivy tests that ran on the PR. ✔️
  • New Failures Introduced: This lists the tests that fail on this PR.

Keep in mind that we will assign an engineer for this task and they will look at it based on the workload that they have, kindly be patient 😄.

@rp097 rp097 changed the title Fixed failures for numpy - linalg.scipy.linalg.norm #28197 Fixed Ivy Failing Test: numpy - linalg.scipy.linalg.norm #28197 Feb 6, 2024
@rp097 rp097 changed the title Fixed Ivy Failing Test: numpy - linalg.scipy.linalg.norm #28197 Fixed Ivy Failing Test: numpy - linalg.scipy.linalg.norm Feb 6, 2024
@rp097 rp097 changed the title Fixed Ivy Failing Test: numpy - linalg.scipy.linalg.norm Fixed Ivy Frontend Test: numpy - linalg.scipy.linalg.norm Feb 6, 2024
@rp097 rp097 closed this Feb 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Frontend Failing Test: numpy - linalg.scipy.linalg.norm
2 participants