From d9ae9b98dcd62f5961bb4d919eaaa4c1cca26213 Mon Sep 17 00:00:00 2001 From: Nicholas Dille Date: Wed, 26 Jun 2024 10:24:03 +0200 Subject: [PATCH 1/2] Fixed hardcoded versions --- tools/axel/Dockerfile.template | 2 +- tools/cosign/Dockerfile.template | 2 +- tools/git/Dockerfile.template | 14 -------- tools/kubeadm/Dockerfile.template | 28 +++++++-------- tools/kubectl/Dockerfile.template | 58 ++++++++++++++---------------- tools/kubelet/Dockerfile.template | 28 +++++++-------- tools/musl/Dockerfile.template | 2 +- tools/nvm/Dockerfile.template | 2 +- tools/tailspin/Dockerfile.template | 6 ++-- 9 files changed, 59 insertions(+), 83 deletions(-) diff --git a/tools/axel/Dockerfile.template b/tools/axel/Dockerfile.template index 6f7c93fce3..adca248a75 100644 --- a/tools/axel/Dockerfile.template +++ b/tools/axel/Dockerfile.template @@ -17,7 +17,7 @@ WORKDIR /tmp/axel ARG name ARG version RUN <.+?)$ ARG COSIGN_VERSION=2.2.3 COPY checksums.txt . RUN <"${prefix}/share/bash-completion/completions/kubeadm" "${prefix}/bin/kubeadm" completion zsh >"${prefix}/share/zsh/vendor-completions/_kubeadm" diff --git a/tools/kubectl/Dockerfile.template b/tools/kubectl/Dockerfile.template index cf750236a3..de59c30534 100644 --- a/tools/kubectl/Dockerfile.template +++ b/tools/kubectl/Dockerfile.template @@ -15,42 +15,36 @@ RUN <"${prefix}/share/bash-completion/completions/kubectl" "${prefix}/bin/kubectl" completion zsh >"${prefix}/share/zsh/vendor-completions/_kubectl" diff --git a/tools/kubelet/Dockerfile.template b/tools/kubelet/Dockerfile.template index a2e4cbb79b..b30e9257bb 100644 --- a/tools/kubelet/Dockerfile.template +++ b/tools/kubelet/Dockerfile.template @@ -16,19 +16,17 @@ curl --silent --show-error --location --fail --output "${prefix}/bin/kubelet" \ "https://storage.googleapis.com/kubernetes-release/release/v${version}/bin/linux/${alt_arch}/kubelet" chmod +x "${prefix}/bin/kubelet" -if test "$(echo -e "1.26.0-beta.0\n${version}" | sort -V | head -n 1)" == "1.26.0-beta.0"; then - echo "Verifying keyless signature for kubelet" - curl --silent --show-error --location --fail --output "/tmp/kubelet.sig" \ - "https://dl.k8s.io/release/v${version}/bin/linux/${alt_arch}/kubelet.sig" - curl --silent --show-error --location --fail --output "/tmp/kubelet.cert" \ - "https://dl.k8s.io/release/v${version}/bin/linux/${alt_arch}/kubelet.cert" - COSIGN_EXPERIMENTAL=1 cosign verify-blob "${prefix}/bin/kubelet" \ - --signature "/tmp/kubelet.sig" \ - --certificate "/tmp/kubelet.cert" \ - --certificate-oidc-issuer https://accounts.google.com \ - --certificate-identity krel-staging@k8s-releng-prod.iam.gserviceaccount.com - rm -f \ - "/tmp/kubelet.sig" \ - "/tmp/kubelet.cert" -fi +echo "Verifying keyless signature for kubelet" +curl --silent --show-error --location --fail --output "/tmp/kubelet.sig" \ + "https://dl.k8s.io/release/v${version}/bin/linux/${alt_arch}/kubelet.sig" +curl --silent --show-error --location --fail --output "/tmp/kubelet.cert" \ + "https://dl.k8s.io/release/v${version}/bin/linux/${alt_arch}/kubelet.cert" +COSIGN_EXPERIMENTAL=1 cosign verify-blob "${prefix}/bin/kubelet" \ + --signature "/tmp/kubelet.sig" \ + --certificate "/tmp/kubelet.cert" \ + --certificate-oidc-issuer https://accounts.google.com \ + --certificate-identity krel-staging@k8s-releng-prod.iam.gserviceaccount.com +rm -f \ + "/tmp/kubelet.sig" \ + "/tmp/kubelet.cert" EOF \ No newline at end of file diff --git a/tools/musl/Dockerfile.template b/tools/musl/Dockerfile.template index 5ea8dfedda..2dd3732c7d 100644 --- a/tools/musl/Dockerfile.template +++ b/tools/musl/Dockerfile.template @@ -12,7 +12,7 @@ WORKDIR /tmp/musl ARG name ARG version RUN < Date: Wed, 26 Jun 2024 12:50:20 +0200 Subject: [PATCH 2/2] No proper binary --- tools/nvm/manifest.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/nvm/manifest.yaml b/tools/nvm/manifest.yaml index 6d23d9ddc3..fe9b47cd25 100644 --- a/tools/nvm/manifest.yaml +++ b/tools/nvm/manifest.yaml @@ -1,6 +1,7 @@ # yaml-language-server: $schema=https://tools.uniget.dev/schema.yaml name: nvm version: "0.39.7" +binary: "false" check: "" # No version parameter platforms: - linux/amd64