Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove chainspec from the beacon api client #2705

Closed
benluelo opened this issue Aug 8, 2024 · 1 comment
Closed

remove chainspec from the beacon api client #2705

benluelo opened this issue Aug 8, 2024 · 1 comment
Labels
C-enhancement Category: An issue proposing an enhancement or a PR with one.

Comments

@benluelo
Copy link
Contributor

benluelo commented Aug 8, 2024

this is super annoying to deal with. we should instead have "unbounded" versions of all of the types, with a way to convert to the "bounded" version where needed. something like this:

let block = beacon_api_client.block().await;
let mainnet_block: Block<Mainnet> = block.try_into().unwrap();

the only time the chainspec matters is when doing consensus verification. having it be part of the beacon client itself makes the client practically useless for other usecases (a prime example is hubble).

this will likely involve creating new "unbounded" versions of all types with a <C: ...> generic parameter, either through a proc macro or manually (probably manually).

  • todo: how to name these types?
@benluelo benluelo added the C-enhancement Category: An issue proposing an enhancement or a PR with one. label Aug 8, 2024
@benluelo
Copy link
Contributor Author

this was included in #2661

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Category: An issue proposing an enhancement or a PR with one.
Projects
None yet
Development

No branches or pull requests

1 participant