Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ArtifactReport.has_* should not rely on the implementation of with_* #10

Open
pederhan opened this issue Nov 29, 2022 · 0 comments
Open

Comments

@pederhan
Copy link
Member

pederhan commented Nov 29, 2022

Why create a whole new report and check its artifacts, when we should just be able to do

return any(artifact.has_foo("...") for artifact in self.artifacts)

We already do this with all has_* methods except has_repository and has_severity.

@pederhan pederhan added this to Harbor Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant