Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic list of characters #49

Open
Charlynux opened this issue Jun 10, 2017 · 1 comment
Open

Dynamic list of characters #49

Charlynux opened this issue Jun 10, 2017 · 1 comment

Comments

@Charlynux
Copy link

Hello,

I was at your talk yesterday. (I was the guy who asked you if you put some Cycle.js app in production.)
During your presentation, you said having problems with dynamic lists.
I write a quick (and dirty) modification of your app to accept a stream of characters.
You can find the source code here : https://github.com/Charlynux/cycle-music/tree/dirty-characters-stream.

I think the difficulty comes from the absence of a "characters" Cycle component, taking a characters stream as source.
I have another refactor in progress to create some more Cycle components.

@fabienjuif
Copy link
Member

Thank you @Charlynux this is very kind of you.
This is very enjoyable !

I looked at the diff (master...Charlynux:dirty-characters-stream#diff-801485c22b2eeef7ff39fa3bfcaadf8f)

I'm looking forward seeing your further modifications.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants