-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Would you be willing to sign the ECA to make your contributions available for Eclipse? #107
Comments
@keilw you know that I'm a big promoter of your project, and I even poured a lot of money into it along with a developer to get UCUM working. But at the end of the day the So at the moment I'm leery of associating my name and my company's name with a project that is broken. The project does not work for UCUM. It does not work. So maybe you could provide an update on #97 and let me know when you will fix the |
Actually it's all working in master based on https://github.com/unitsofmeasurement/uom-se/releases/tag/1.0.7 released about a week ago. uom-systems isn't just about UCUM and while I may not add all the UCUM units missing yet, there is just one issue open for https://github.com/unitsofmeasurement/uom-systems/milestone/4. Target date is the 17th, so the end of this week. I want to add all reasonable units from Unicode CLDR 31/ICU 59 (not every multiple and submultiple is reasonable, you can do all combinations with There are at least 3 or 4 contributors to systems-quantity. One type is not even used, so it could be moved into another module if the worst comes to the worst. Every quantity type we could not get approved would have to be substituted with Dimensionless or something written from scratch. However there is no great rush. Eclipse can be a bit slow especially when its own Release Train is rolling this month, so no extreme hurry. If systems 0.7.1 makes you feel confident enough, then happy to discuss it further after its release. |
Heey @keilw, thank you for remember of me, and @garretwilson, thank you for assume it while I was busy with other projects. I took some time to test the units, and although they seem well formatted at first, it's not completely working yet. It will probably be an easier work than the one that we've been through (and I couldn't help to fix, for known reasons). Here is what I tested, I used a simply
And the prefix is being formatted pretty good in this case:
But if I combine some multiplications things get weird:
If I simply multiply something that's in the range of a prefix, it'll format again, and won't combine with the current prefix that's already there.
So although it's functional with simple cases, where the user would simply get the unit with the prefix already, it's not functional for operations with it. You need to fix it before saying that it's everything working, but it looks pretty good @keilw, you (and the people who contributed with the prefixes issue) made a great progress there, it's great to see that! |
@magnonasc Thanks for trying it and the detailed analysis.
The first one passes, the second currently won't. We'll have to see, how chained operations can be supported in a future version. And what level of nesting is reasonable. Also please advise what you'd expect,
So combining something like |
@magnonasc Please see the new ticket #108. If you have time feel free to comment or make suggestions there. This ticket is only to track the ECA issue which needs to be resolved sooner or later. |
@garretwilson @magnonasc Hi, |
Thanks for the reminder, @keilw . @magnonasc and I will address this this week. |
Hi, @keilw . I was worried about the personal information on the agreement, but checked with the Eclipse Foundation and they said they keep it confidential. But the thing that confuses me is that I don't see anything on the agreement that specifies which Contribution is being referred to. It says:
So I guess that just means "anything you submit to Eclipse, and Werner is doing that for you"? |
Yes, Eclipse Foundation does not bind this to a project at least not for he ECA, otherwise it could be like JCP where the old "Exhibit B" had to be approved for every JSR. |
How's the progress with the ECA? I am just about to upload the sources of system-quantity-0.7.2 which contains @magnonasc's contribution. Depending on how thorough the IP team is on it, every contributor who is mentioned in a file could be checked for their ECA. If the worst comes to the worst we would have to patch the library and remove unsanctioned quantities, but I hope we don't have to. TIA |
@keilw, I signed the ECA. Sorry if you received a notification from another account. |
@magnonasc Thanks, I have not, but I don't think Eclipse does that for every project. The libraries were both approved with their CQ, so that also confirms they have everything they need. Thanks a lot for signing it. As contributor if you were interested, that also would give you an opportunity to contribute to Eclipse UOMo including the "late binding" but very compatible UCUM libraries that AFAIR pass all the UCUM TCKs as well. |
I close this ticket now as it was to track the ECA. |
Hi,
Thanks again for your contributions to uom-systems, especially the UCUM part.
I made relevant system modules available as P2 repository on https://bintray.com/unitsofmeasurement/p2/systems.uom_p2_site
However, for Eclipse projects to use it, e.g. those under https://science.eclipse.org/ everyone who contributed something has to sign a so-called Eclipse Contributor Agreement (https://www.eclipse.org/legal/ECA.php), that would be mostly @magnonasc
Would that be OK for you? Otherwise only the "late binding" Eclipse UOMo implementation that's already under Eclipse License would be usable. UOMo 0.8 combines uom-se and UOMo, but right now it only uses https://github.com/unitsofmeasurement/uom-systems/tree/master/quantity (which @magnonasc also contributed, to, so without having to remove certain quantity types Eclipse also requires his ECA for that, there is just one per contributor not per module ;-)
TIA,
Werner
The text was updated successfully, but these errors were encountered: