Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JamfRecordNotFound class missing attribute #85

Open
bonallure opened this issue Jun 12, 2024 · 1 comment
Open

JamfRecordNotFound class missing attribute #85

bonallure opened this issue Jun 12, 2024 · 1 comment

Comments

@bonallure
Copy link

Hello, it looks like the JamfRecordNotFound Error class is missing the attribute response. This causes it to not be properly returned when a record is not found, producing a type error instead.

raise exceptions.JamfRecordNotFound(response, "Not Found")
      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

TypeError: Error.init() takes from 1 to 2 positional arguments but 3 were given

@magnusviri
Copy link
Collaborator

Hi, I searched for this text and it looks like it's part of the api.py file in _submit_request(), is that right? We have deprecated this file and that's probably why we didn't catch this bug. We aren't actively testing this file. If you're using it, please switch to the much more capable jps-api-wrapper.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants