-
Notifications
You must be signed in to change notification settings - Fork 620
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JavaScript: destructural binding #1112
Comments
I also get this warning with array destructuring, i.e. this pattern : |
#2115 Though I opened the pull request, the way to fix the issue in the pull request looks a bit tricky for me. I will fix this but I cannot say when. I have to finish rewriting R parser. See also #2494. |
Related to universal-ctags#900, universal-ctags#1112, and universal-ctags#3427. When the parser tries making a tag with empty name, an assertion in registerEntry fails. The parser side should be fixed but it will take a time. This change puts guard conditions around registerEntry to avoid the failures. THIS IS A TEMPORARILY SOLUTION. Signed-off-by: Masatake YAMATO <yamato@redhat.com>
I'm working on this item.
|
Close universal-ctags#1112. Signed-off-by: Masatake YAMATO <yamato@redhat.com>
Close universal-ctags#1112. Signed-off-by: Masatake YAMATO <yamato@redhat.com>
Close universal-ctags#1112. Signed-off-by: Masatake YAMATO <yamato@redhat.com>
Close universal-ctags#1112. Signed-off-by: Masatake YAMATO <yamato@redhat.com>
Close universal-ctags#1112. Signed-off-by: Masatake YAMATO <yamato@redhat.com>
Close universal-ctags#1112. Signed-off-by: Masatake YAMATO <yamato@redhat.com>
When playing with various languages I ran into this warning for this file:
https://github.com/facebook/react/blob/master/src/renderers/shared/fiber/ReactFiberBeginWork.js
It looks the code doesn't like lines like
and the warning comes from
https://github.com/universal-ctags/ctags/blob/master/parsers/jscript.c#L1778
because the
name
tag isn't checked whether it's an identifier or something else - it's probably { in this case.Not a js developer myself so leaving this to someone who knows the correct syntax.
The text was updated successfully, but these errors were encountered: