Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

peer.close() does not pass code and reason to hooks #82

Open
WerdoxDev opened this issue Sep 29, 2024 · 0 comments
Open

peer.close() does not pass code and reason to hooks #82

WerdoxDev opened this issue Sep 29, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@WerdoxDev
Copy link

Environment

Bun 1.1.29
Crossws 0.3.1

Reproduction

  1. Create a bun crossws instance
  2. Define a close hook
  3. Run peer.close(4001, "some reason");

Describe the bug

using peer.close(4001, "some-reason") does not pass the code and reason to the close hook.

It seems that an empty {} object is being passed to it.

hooks.callHook("close", peer, {});

Additional context

No response

Logs

No response

@WerdoxDev WerdoxDev added the bug Something isn't working label Sep 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant