Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move cache directory on Windows to AppData #178

Open
1 task done
RihanArfan opened this issue Jul 20, 2024 · 1 comment · May be fixed by #182
Open
1 task done

Move cache directory on Windows to AppData #178

RihanArfan opened this issue Jul 20, 2024 · 1 comment · May be fixed by #182
Labels
enhancement New feature or request

Comments

@RihanArfan
Copy link

RihanArfan commented Jul 20, 2024 •
edited
Loading

Describe the feature

The disk cache folder on Windows resides in C:\Users\<user>\.cache\giget, which applies Linux/macOS standards to Windows. I suggest we move it to the correct Windows folder, which would be C:\Users\<user>\AppData\Local\Temp\giget.

giget/src/_utils.ts

Lines 96 to 100 in a2acbcc

export function cacheDirectory() {
return process.env.XDG_CACHE_HOME
? resolve(process.env.XDG_CACHE_HOME, "giget")
: resolve(homedir(), ".cache/giget");
}

Explanation of the issue: dotnet/templating#852

Additional information

  • Would you be willing to help implement this feature?
@RihanArfan RihanArfan added the enhancement New feature or request label Jul 20, 2024
@pi0
Copy link
Member

pi0 commented Jul 21, 2024

Thanks for suggestion. PR welcome for change 👍🏼

@RihanArfan RihanArfan linked a pull request Aug 2, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: use correct windows temp directory RihanArfan/giget
2 participants
@pi0 @RihanArfan