Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make request and response types explicit #489

Merged
merged 1 commit into from
Aug 7, 2023
Merged

fix: make request and response types explicit #489

merged 1 commit into from
Aug 7, 2023

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe self-assigned this Aug 4, 2023
@codecov
Copy link

codecov bot commented Aug 4, 2023

Codecov Report

Merging #489 (724964b) into main (6c14ff9) will increase coverage by 0.52%.
The diff coverage is 100.00%.

❗ Current head 724964b differs from pull request most recent head 4686f57. Consider uploading reports for the commit 4686f57 to get more accurate results

@@            Coverage Diff             @@
##             main     #489      +/-   ##
==========================================
+ Coverage   82.27%   82.79%   +0.52%     
==========================================
  Files          31       31              
  Lines        3481     3424      -57     
  Branches      516      515       -1     
==========================================
- Hits         2864     2835      -29     
+ Misses        617      589      -28     
Files Changed Coverage Ξ”
src/event/utils.ts 72.38% <100.00%> (+9.70%) ⬆️

... and 2 files with indirect coverage changes

@danielroe danielroe marked this pull request as ready for review August 7, 2023 07:51
@pi0 pi0 changed the title fix: make request/response types explicit fix: make request and response types explicit Aug 7, 2023
@pi0 pi0 merged commit 3b64c18 into main Aug 7, 2023
@pi0 pi0 deleted the fix/any-types branch August 7, 2023 08:50
@pi0 pi0 mentioned this pull request Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants