diff --git a/.eslintignore b/.eslintignore deleted file mode 100644 index 2d67725..0000000 --- a/.eslintignore +++ /dev/null @@ -1,3 +0,0 @@ -dist -coverage -src/lib diff --git a/.eslintrc b/.eslintrc deleted file mode 100644 index 21484d0..0000000 --- a/.eslintrc +++ /dev/null @@ -1,7 +0,0 @@ -{ - "extends": ["eslint-config-unjs"], - "rules": { - "unicorn/consistent-destructuring": 0, - "@typescript-eslint/no-non-null-assertion": 0 - } -} diff --git a/README.md b/README.md index 6985095..d79bee6 100644 --- a/README.md +++ b/README.md @@ -104,7 +104,7 @@ const handler = (req, res) => { } // listener: { url, getURL, server, close, ... } -const listener = await listen(handler, options?) +const listener = await listen(handler, options) ``` ## Options diff --git a/eslint.config.mjs b/eslint.config.mjs new file mode 100644 index 0000000..a31bec2 --- /dev/null +++ b/eslint.config.mjs @@ -0,0 +1,13 @@ +import unjs from "eslint-config-unjs"; + +// https://github.com/unjs/eslint-config +export default unjs({ + ignores: [ + "src/lib" +], + rules: { + "unicorn/consistent-destructuring": 0, + "@typescript-eslint/no-non-null-assertion": 0, + "unicorn/no-anonymous-default-export": 0, +}, +}); diff --git a/src/server/_resolver.ts b/src/server/_resolver.ts index d3035cf..3bde0a3 100644 --- a/src/server/_resolver.ts +++ b/src/server/_resolver.ts @@ -20,7 +20,9 @@ export async function createResolver() { const tryResolve = (id: string) => { try { return resolve(id); - } catch {} + } catch { + // Ignore errors + } }; return { diff --git a/src/server/dev.ts b/src/server/dev.ts index c68c8f3..b6a843d 100644 --- a/src/server/dev.ts +++ b/src/server/dev.ts @@ -207,7 +207,9 @@ function normalizeErrorStack(error: Error) { .map((l) => l.replace(cwd, ".")) .filter((l) => !InternalStackRe.test(l)) .join("\n"); - } catch {} + } catch { + // Ignore errors + } return error; } diff --git a/src/server/watcher.ts b/src/server/watcher.ts index 673f8d9..01f5fad 100644 --- a/src/server/watcher.ts +++ b/src/server/watcher.ts @@ -18,7 +18,7 @@ export async function listenAndWatch( options: Partial, ): Promise { const logger = options.logger || consola.withTag("listhen"); - let watcher: AsyncSubscription; // eslint-disable-line prefer-const + let watcher: AsyncSubscription; // Create dev server const devServer = await createDevServer(entry, { diff --git a/test/cert.test.ts b/test/cert.test.ts index 6acec39..7afc60f 100644 --- a/test/cert.test.ts +++ b/test/cert.test.ts @@ -4,7 +4,6 @@ import { resolve } from "pathe"; import { Listener } from "../src"; import { TLSCertOptions, _private } from "../src/_cert"; -// eslint-disable-next-line no-console // console.log = fn() function assertDefaultAttributes(attrs: forge.pki.CertificateField[]) { diff --git a/test/index.test.ts b/test/index.test.ts index 3cf2142..c7cd2f5 100644 --- a/test/index.test.ts +++ b/test/index.test.ts @@ -3,7 +3,6 @@ import type { IncomingMessage, ServerResponse } from "node:http"; import { describe, afterEach, test, expect } from "vitest"; import { listen, Listener } from "../src"; -// eslint-disable-next-line no-console // console.log = fn() function handle(request: IncomingMessage, response: ServerResponse) { @@ -43,7 +42,7 @@ describe("listhen", () => { }); expect(listener.url.startsWith("http://")).toBe(true); expect(listener.url.endsWith("/foo/bar")).toBe(true); - // eslint-disable-next-line no-console + // expect(console.log).toHaveBeenCalledWith(expect.stringMatching('\n > Local: http://localhost:3000/foo/bar')) }); @@ -56,9 +55,8 @@ describe("listhen", () => { test("listen (https - custom)", async () => { listener = await listen(handle, { https: { - // eslint-disable-next-line unicorn/prefer-module key: resolve(__dirname, ".tmp/certs", "key.pem"), - // eslint-disable-next-line unicorn/prefer-module + cert: resolve(__dirname, ".tmp/certs", "cert.pem"), }, hostname: "localhost", @@ -69,9 +67,8 @@ describe("listhen", () => { test("listen (https - custom - with private key passphrase)", async () => { listener = await listen(handle, { https: { - // eslint-disable-next-line unicorn/prefer-module key: resolve(__dirname, ".tmp/certs", "encrypted-key.pem"), - // eslint-disable-next-line unicorn/prefer-module + cert: resolve(__dirname, ".tmp/certs", "cert.pem"), passphrase: "cert-pw", }, @@ -87,9 +84,8 @@ describe("listhen", () => { expect(() => listen(handle, { https: { - // eslint-disable-next-line unicorn/prefer-module key: resolve(__dirname, ".tmp/certs", "encrypted-key.pem"), - // eslint-disable-next-line unicorn/prefer-module + cert: resolve(__dirname, ".tmp/certs", "cert.pem"), passphrase: "wrong-pw", }, @@ -102,7 +98,6 @@ describe("listhen", () => { test("listen (https - PCKS#12/pfx/p12 - with store passphrase)", async () => { const listener = await listen(handle, { https: { - // eslint-disable-next-line unicorn/prefer-module pfx: resolve(__dirname, ".tmp/certs/keystore.p12"), passphrase: "store-pw", }, @@ -115,7 +110,6 @@ describe("listhen", () => { expect(() => listen(handle, { https: { - // eslint-disable-next-line unicorn/prefer-module pfx: resolve(__dirname, ".tmp/certs/keystore.p12"), }, hostname: "localhost", @@ -129,7 +123,6 @@ describe("listhen", () => { expect(() => listen(handle, { https: { - // eslint-disable-next-line unicorn/prefer-module pfx: resolve(__dirname, ".tmp/certs/keystore.p12"), passphrase: "wrong-pw", }, diff --git a/test/setup.ts b/test/setup.ts index 50864b2..badb405 100644 --- a/test/setup.ts +++ b/test/setup.ts @@ -6,7 +6,6 @@ import { _private } from "../src/_cert"; export async function setup() { if (!existsSync(resolve("test/.tmp/certs/cert.pem"))) { - // eslint-disable-next-line unicorn/prefer-top-level-await const start = Date.now(); console.log("Generating certificates..."); await generateCert();