Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Node by default with Cloudflare Pages preset #1314

Closed
1 task done
Smef opened this issue Jun 16, 2023 · 1 comment
Closed
1 task done

Enable Node by default with Cloudflare Pages preset #1314

Smef opened this issue Jun 16, 2023 · 1 comment

Comments

@Smef
Copy link

Smef commented Jun 16, 2023

Describe the feature

When deploying on Cloudflare Pages the cloudflare-pages preset has node: false as a configuration option, which is incorrect. CFP v1 uses Node 12 by default, with Node 18 as the default in the new v2 beta. You can also specify any specific Node version you want for your deployment, which is what you'd need to do to deploy on CFP. (https://developers.cloudflare.com/pages/platform/language-support-and-tools/)

I think that the default for a CFP preset should be node: true.

PR: #1315

Additional information

  • Would you be willing to help implement this feature?
@pi0
Copy link
Member

pi0 commented Jun 18, 2023

We do use Node.js for building nitro apps. More context #1315 (comment)

@pi0 pi0 closed this as not planned Won't fix, can't repro, duplicate, stale Jun 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants