Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(options): exclude buildDir for auto-imports #355

Merged
merged 5 commits into from
Jul 21, 2022
Merged

Conversation

danielroe
Copy link
Member

@danielroe danielroe commented Jul 19, 2022

πŸ”— Linked issue

nuxt/framework#5981, nuxt/bridge#421

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This disables processing the build output of the previous step from auto-imports. Credit to @cinob for spotting the issue; this just moves the fix up to Nitro if we think that makes sense.

cc: @antfu

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added the bug Something isn't working label Jul 19, 2022
@danielroe danielroe requested a review from pi0 July 19, 2022 20:55
@danielroe danielroe self-assigned this Jul 19, 2022
src/options.ts Outdated Show resolved Hide resolved
@pi0 pi0 changed the title fix: don't process build output for auto-imports fix(options): exclude buildDir for auto-imports Jul 21, 2022
@pi0 pi0 merged commit 5219c53 into main Jul 21, 2022
@pi0 pi0 deleted the fix/unimport-build-dir branch July 21, 2022 08:33
WinterYukky pushed a commit to WinterYukky/nitro that referenced this pull request Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants