Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: include dotfiles in public assets #361

Merged
merged 1 commit into from
Jul 27, 2022
Merged

fix: include dotfiles in public assets #361

merged 1 commit into from
Jul 27, 2022

Conversation

danielroe
Copy link
Member

@danielroe danielroe commented Jul 21, 2022 •
edited
Loading

🔗 Linked issue

nuxt/nuxt#13977

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

It's common to need static files served on . prefixed paths, e.g. .well-known.

Currently we were ignoring them when scanning.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added the bug Something isn't working label Jul 21, 2022
@danielroe danielroe requested a review from pi0 July 21, 2022 15:00
@danielroe danielroe self-assigned this Jul 21, 2022
@pi0 pi0 changed the title fix: allow publicassets to contain dotfiles fix: include dotfiles in public assets Jul 27, 2022
@pi0 pi0 merged commit 8a744fb into main Jul 27, 2022
@pi0 pi0 deleted the fix/allow-dot-assets branch July 27, 2022 09:12
WinterYukky pushed a commit to WinterYukky/nitro that referenced this pull request Nov 1, 2022
@danielroe @WinterYukky
fix: include dotfiles in public assets (unjs#361)
f1eafe0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pi0 pi0 Awaiting requested review from pi0

Assignees

@danielroe danielroe

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danielroe @pi0