Generated package.json is not valid

[TheDutchCoder]

Environment

Node: v16.15.1
Nitro: 0.5.3

Reproduction

Probably doesn't need a reproduction, but let me know if I need to supply a Stackblitz or GH repro

Describe the bug

When using the aws-lamda preset (probably goes for other ones too), the generated package.json is missing the required fields name and version, which means that deploying the code through (for example) SAM fails.

Maybe the name and version could be grabbed from the root's package.json?

Additional context

No response

Logs

No response

[pi0]

Hi @TheDutchCoder. I think the package.json is valid with private: true field to omit name an version and it is only a placeholder meta file. What exact error are you getting?

[pi0]

BTW surely we can add placeholder name and version to the file as well 👍🏼

[TheDutchCoder]

This probably comes from some form of validator on the AWS side, which (I think) assumes the package is a publishable one.

I can't find any docs that say private: true make name and version not required, but I also can't find any docs that they are required when setting private: true haha.

NPM themselves mark name and version as required: https://docs.npmjs.com/creating-a-package-json-file so I think that's what the AWS validator uses as a base.

I'm more than willing to PR this, but I couldn't find the root's imported package.json in the code that generates the output package.json. I think it might be a good idea to grab the name and version from the root's file, with backup values in case they're missing?

[pi0]

Well there is not single standard across package managers. Some only require version... I think it should be fine using stub name and version for the output like { name: "nitro-output", version: "0.0.0" }

[TheDutchCoder]

Yeah that sounds good, do you want me to PR it?

[pi0]

Sure thanks ❤️

[TheDutchCoder]

Ready!