Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore .DS_Store files from public assets and compression #940

Open
leosin opened this issue Feb 12, 2023 · 2 comments
Open

Ignore .DS_Store files from public assets and compression #940

leosin opened this issue Feb 12, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@leosin
Copy link

leosin commented Feb 12, 2023

Environment

nitro: 2.1.1
node: 18

Reproduction

image

 nitro: {
    compressPublicAssets: true, 
  },

Describe the bug

When the compression option is turned on, there will be .DS_Store.br and .DS_store.gz files in each directory after building.

Can this file be ignored by default?

or some option in config can exclude it.

Additional context

No response

Logs

No response

@manniL manniL changed the title include .DS_Store files on compressPublicAssets Remove .DS_Store files on compressPublicAssets Feb 12, 2023
@manniL manniL changed the title Remove .DS_Store files on compressPublicAssets Remove .DS_Store files on compressPublicAssets Feb 12, 2023
@VladStepanov
Copy link

.DS_Store is macOS-specific files and generated when you open directory through Finder. You should handle it manually and delete

@pi0
Copy link
Member

pi0 commented Feb 13, 2023

Generally, we should support ignore patterns for public directory (#843)

PR is welcome to add a hotfix to ignore this specific file from copying in public assets plugin.

@pi0 pi0 added bug Something isn't working enhancement New feature or request and removed pending triage labels Feb 13, 2023
@pi0 pi0 changed the title Remove .DS_Store files on compressPublicAssets Ignore .DS_Store files from public assets and compression May 16, 2024
@pi0 pi0 removed the bug Something isn't working label May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants