Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(externals): compare package paths against normalized id #2371

Merged
merged 5 commits into from
Apr 29, 2024
Merged

fix(externals): compare package paths against normalized id #2371

merged 5 commits into from
Apr 29, 2024

Conversation

markthree
Copy link
Contributor

🔗 Linked issue

close #2367

❓ Type of change

  • 📖 Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

This was referenced Apr 17, 2024
Closed
Closed
@pi0 pi0 changed the title fix: externals comparation match on windows fix(externals): compare package paths against normalized id Apr 29, 2024
pi0
pi0 approved these changes Apr 29, 2024
View reviewed changes
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks ❤️

@pi0 pi0 merged commit b2f4523 into nitrojs:main Apr 29, 2024
4 checks passed
@pi0 pi0 mentioned this pull request Jun 13, 2024
Closed
@Barbapapazes Barbapapazes mentioned this pull request Aug 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pi0 pi0 pi0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

externals comparison mismatch on windows
2 participants
@markthree @pi0