fix(prerender): only extract relative links #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pi0
reviewed
Apr 14, 2022
src/prerender.ts
Outdated
| @@ -80,7 +80,9 @@ const LINK_REGEX = /href=['"]?([^'" >]+)/g | |||
| function extractLinks (html: string, _url: string) { | |||
| const links: string[] = [] | |||
| for (const match of html.matchAll(LINK_REGEX)) { | |||
| links.push(parseURL(match[1]).pathname) | |||
| const url = parseURL(match[1]) | |||
| // Extract only relative links | |||
There was a problem hiding this comment.
Currently we don't support relative links either (see _url above is unused)
There was a problem hiding this comment.
What I meant is excluding the url that includes a host (external urls).
|
Added tests and an improvement to pass relative links as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
Related to https://github.com/nuxt/nuxt3-docs/issues/21
❓ Type of change
📚 Description
The crawler should only extract the relative link. I don't know where to add a test case, I did test in the nuxt 3 upcoming docs and fixes the isssue.
📝 Checklist