fix: wrap dynamic import in prerender to fix windows build failure #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We really need this to be able to generate static pages with nuxt3 on Windows 10 |
pi0
changed the title
pi0
approved these changes
Apr 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
nuxt/nuxt#13731
❓ Type of change
📚 Description
This fixes a bug, when a fresh install of nuxt3 on Windows can not produce a build. It is failing with an error related to files paths. It seems like all dynamic imports should be wrapped with
pathToFileURLto work properly on Windows.Also fixed a minor bug with configuration. Cloudflare test failed on Windows.
📝 Checklist