Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add seo #2090

Closed
wants to merge 1 commit into from
Closed

docs: add seo #2090

wants to merge 1 commit into from

Conversation

Barbapapazes
Copy link
Member

@Barbapapazes Barbapapazes commented Jan 16, 2024

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This add some basic SEO (waiting for a more moderne documentation with Nuxt UI to improve it more).

I will make another PR to add description to each page.

There is some bug I need to upstream to Nuxt SEO. In the schemaOrg config, the key name is no known and the key logo does nothing. https://nuxtseo.com/schema-org/guides/quick-setup#setup

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@Barbapapazes Barbapapazes added the documentation Improvements or additions to documentation label Jan 16, 2024
@Barbapapazes Barbapapazes self-assigned this Jan 16, 2024
@Barbapapazes Barbapapazes requested a review from pi0 January 16, 2024 23:18
@pi0
Copy link
Member

pi0 commented Jan 17, 2024

Thanks! Would you mind to rebase it against the new UI pro branch? (#1961)

@Barbapapazes
Copy link
Member Author

Thanks! Would you mind to rebase it against the new UI pro branch? (#1961)

I will make another PR to use unjs/docs package and SEO will come for unjs/undocs#5.

@pi0 pi0 mentioned this pull request Jan 23, 2024
2 tasks
@pi0
Copy link
Member

pi0 commented Jan 23, 2024

Okay added to todo list for #1961

(closing only because there are too many open PRs..)

@pi0 pi0 closed this Jan 23, 2024
@pi0 pi0 deleted the docs/seo branch January 23, 2024 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants