Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow overriding nested variables #75

Merged
merged 1 commit into from
Apr 12, 2022
Merged

fix: allow overriding nested variables #75

merged 1 commit into from
Apr 12, 2022

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

reverts 686320e

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Returning true allows for overriding nested variables.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added the bug Something isn't working label Apr 12, 2022
@danielroe danielroe requested a review from pi0 April 12, 2022 10:23
@danielroe danielroe self-assigned this Apr 12, 2022
@pi0
Copy link
Member

pi0 commented Apr 12, 2022

You are right. It stopped working i was trying on a workaround to support NITRO_FOO + NITRO_FOO_BAR and needed this fix but seems more complicated issue.

@pi0 pi0 merged commit d7bfc96 into main Apr 12, 2022
@pi0 pi0 deleted the fix/allow-overriding branch April 12, 2022 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants