Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check for globalThis before fallback to shims #20

Merged
merged 5 commits into from
Oct 22, 2021

Conversation

ms-fadaei
Copy link
Contributor

I just updated the getGlobal function to get the best result! Not a significant change at all 😄

src/index.ts Outdated Show resolved Hide resolved
src/index.ts Show resolved Hide resolved
@ms-fadaei
Copy link
Contributor Author

My mistake. I just tried to add some code from the browser (so there isn't any type checking). Then I cloned the project on my local machine and here we go! after five commits, I just added globalThis :))

@pi0 pi0 changed the title refactor: update getGlobal function based on latest standards fix: check for globalThis before fallback to shims Oct 22, 2021
@pi0 pi0 merged commit b5c0c3b into unjs:main Oct 22, 2021
@ms-fadaei ms-fadaei deleted the refactor/global-object branch October 23, 2021 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants