Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Route-matcher is not matching the most specific rule #44

Closed
thezzisu opened this issue Mar 21, 2023 · 2 comments · Fixed by #45
Closed

Route-matcher is not matching the most specific rule #44

thezzisu opened this issue Mar 21, 2023 · 2 comments · Fixed by #45

Comments

@thezzisu
Copy link

Environment

node: v18.14.1
radix3: "radix3@npm:1.0.0"

Reproduction

See https://github.com/lcpu-club/mirror-frontend. Reproduction steps are:

image

image

Simple swapping the rules will affect the output.

Originally posted by @thezzisu in unjs/nitro#1033 (comment)

Describe the bug

Route-matcher is not matching the most specific rule.

Additional context

See unjs/nitro#1033 for more details.

Logs

No response
@pi0
Copy link
Member

pi0 commented Mar 22, 2023

I'm not sure issue is with radix3 matcher. Nitro prerenderer is not using radix3 (and that's the issue itself :D) ~> unjs/nitro#1078

@pi0 pi0 closed this as completed Mar 22, 2023
@pi0 pi0 reopened this Mar 27, 2023
@pi0
Copy link
Member

pi0 commented Mar 27, 2023

Appologies. There was an issue only with matchAll. Solving with #45

@pi0 pi0 mentioned this issue Mar 27, 2023
Merged
@pi0 pi0 closed this as completed in #45 Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(matchAll): sort routes with same type unjs/rou3
2 participants
@pi0 @thezzisu