Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(unlock-app): Migrate to next-captcha-v3 for reCAPTCHA handling #15405

Merged
merged 12 commits into from
Jan 31, 2025

Conversation

0xTxbi
Copy link
Member

@0xTxbi 0xTxbi commented Jan 31, 2025

Description

This PR introduces a migration from react-google-captcha to next-captcha-v3, providing a more modern and Next.js-optimized solution for reCAPTCHA handling.

Screengrabs

Screenshot 2025-01-31 at 12 31 49 Screenshot 2025-01-31 at 12 32 23

Issues

Fixes #
Refs #15358

Checklist:

  • 1 PR, 1 purpose: my Pull Request applies to a single purpose
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the docs to reflect my changes if applicable
  • I have added tests (and stories for frontend components) that prove my fix is effective or that my feature works
  • I have performed a self-review of my own code
  • If my code involves visual changes, I am adding applicable screenshots to this thread

@0xTxbi 0xTxbi requested a review from julien51 January 31, 2025 11:46
@cla-bot cla-bot bot added the cla-signed label Jan 31, 2025
Copy link

vercel bot commented Jan 31, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
unlock-static-site ⬜️ Ignored (Inspect) Jan 31, 2025 0:28am
unlock-storybook ⬜️ Ignored (Inspect) Jan 31, 2025 0:28am

Copy link
Member

@julien51 julien51 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good! We will need to do extensive testing on staging for all scneraii where we use capctcha!

Plaese check the locksmith routes on which it is checked and make sure you test the application flows where any of these routes is being used/

@0xTxbi
Copy link
Member Author

0xTxbi commented Jan 31, 2025

Very good! We will need to do extensive testing on staging for all scneraii where we use capctcha!

Plaese check the locksmith routes on which it is checked and make sure you test the application flows where any of these routes is being used/

sure thing!

@0xTxbi 0xTxbi merged commit 2b9465d into master Jan 31, 2025
16 checks passed
@0xTxbi 0xTxbi deleted the captcha-upgrade branch January 31, 2025 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants