Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deployed Unlock to Astar zkEVM #13468

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

@cla-bot cla-bot bot added the cla-signed label Mar 14, 2024
@julien51 julien51 requested a review from clemsos March 21, 2024 01:32
@julien51
Copy link
Member

julien51 commented Apr 1, 2024

Hey @pavvann I would love to move forward with this! What's the status here?

@pavvann
Copy link
Contributor Author

pavvann commented Apr 3, 2024

Hey @pavvann I would love to move forward with this! What's the status here?

  1. Graph waiting to be deployed as discussed on Discord https://discord.com/channels/462280183425138719/835883531438653460/1217866429106360431
  2. Need to transfer ownership for multisig https://discord.com/channels/462280183425138719/835883531438653460/1217869796972953630

@clemsos
Copy link
Member

clemsos commented May 6, 2024

@pavvann Is safe multisig service deployed on Astar ?

@pavvann
Copy link
Contributor Author

pavvann commented May 7, 2024

@pavvann Is safe multisig service deployed on Astar ?

@clemsos no. i think i have to transfer ownership to unlock-protocol.eth?

@clemsos
Copy link
Member

clemsos commented May 28, 2024

@pavvann Is safe multisig service deployed on Astar ?

@clemsos no. i think i have to transfer ownership to unlock-protocol.eth?

seems Astar zkEVM is in the process of being added to safe safe-global/safe-deployments#404

you could create a safe using the command yarn hardhat safe:create --network astarzkevm then transfer the ownership of contracts and proxyadmin there. What is the best way to get native tokens for the network?

@pavvann
Copy link
Contributor Author

pavvann commented Sep 12, 2024

@pavvann Is safe multisig service deployed on Astar ?

@clemsos no. i think i have to transfer ownership to unlock-protocol.eth?

seems Astar zkEVM is in the process of being added to safe safe-global/safe-deployments#404

you could create a safe using the command yarn hardhat safe:create --network astarzkevm then transfer the ownership of contracts and proxyadmin there. What is the best way to get native tokens for the network?

let me try to create the safe and transfer ownership

@pavvann
Copy link
Contributor Author

pavvann commented Sep 15, 2024

@pavvann Is safe multisig service deployed on Astar ?

@clemsos no. i think i have to transfer ownership to unlock-protocol.eth?

seems Astar zkEVM is in the process of being added to safe safe-global/safe-deployments#404
you could create a safe using the command yarn hardhat safe:create --network astarzkevm then transfer the ownership of contracts and proxyadmin there. What is the best way to get native tokens for the network?

let me try to create the safe and transfer ownership

hi there! i have transferred the ownership to the safe

Safe Address: 0xAf82C931A1a7c751eA8AB2c983619A27b87F8470

ProxyAdmin: https://astar-zkevm.explorer.startale.com/tx/0x9f7ea57b9bfb5ac2b2abffc517d8a1f18d2deea576cac197e823ab0095a95aa9

UnlockProxy: https://astar-zkevm.explorer.startale.com/tx/0xca87b3ee30c0c0acb7d241c7a1441f99334f3700c7b47b4ed007ed57f390a5b9

@pavvann pavvann marked this pull request as ready for review September 15, 2024 10:21
@unlock-deployer
Copy link
Collaborator

packages/networks/src/networks/astarzkevm.ts

The setup is successful :

  • ✅ all mandatory keys are present

We have found the following errors :

  • ❌ Multisig is missing.

Some verification calls have failed :

  • ❌ Failed to check verification for contract PublicLockLatest at 0xA8BD17B22991509F89Eb9861ce88a2Cbdc8bBfF0
    (did you add block explorer verification and API in @unlock-protocol/hardhat-helpers package ?)
  • ❌ Failed to check verification for contract Unlock at 0xeBec66d1f006FEC42633B6fa30b0397de8a4D965
    (did you add block explorer verification and API in @unlock-protocol/hardhat-helpers package ?)
  • ❌ Failed to check verification for contract onKeyPurchaseHook_PASSWORD at 0xe270a288cb5a4633C26B79d8386afa195BcdC610
    (did you add block explorer verification and API in @unlock-protocol/hardhat-helpers package ?)
  • ❌ Could not fetch Unlock source code from block explorer, undefined
  • ❌ Could not fetch PublicLock source code from block explorer, TypeError: Cannot destructure property 'urls' of 'chains.find(...)' as it is undefined.

Some additonal warnings :

  • ⚠️ Contract PublicLockPrevious is missing

@unlock-deployer
Copy link
Collaborator

packages/networks/src/networks/astarzkevm.ts

The setup is successful :

  • ✅ all mandatory keys are present
  • ✅ Unlock ownership correctly set to the multisig

We have found the following errors :

  • ❌ Unexpected policy: 1/9 for 4/9 expected

Some verification calls have failed :

  • ❌ Failed to check verification for contract PublicLockLatest at 0xA8BD17B22991509F89Eb9861ce88a2Cbdc8bBfF0
    (did you add block explorer verification and API in @unlock-protocol/hardhat-helpers package ?)
  • ❌ Failed to check verification for contract Unlock at 0xeBec66d1f006FEC42633B6fa30b0397de8a4D965
    (did you add block explorer verification and API in @unlock-protocol/hardhat-helpers package ?)
  • ❌ Failed to check verification for contract onKeyPurchaseHook_PASSWORD at 0xe270a288cb5a4633C26B79d8386afa195BcdC610
    (did you add block explorer verification and API in @unlock-protocol/hardhat-helpers package ?)
  • ❌ Could not fetch Unlock source code from block explorer, undefined
  • ❌ Could not fetch PublicLock source code from block explorer, TypeError: Cannot destructure property 'urls' of 'chains.find(...)' as it is undefined.

Some additonal warnings :

  • ⚠️ Contract PublicLockPrevious is missing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants