Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Top half of Fab TabBarItem is not clickable #76

Open
2 of 10 tasks
kazo0 opened this issue Oct 27, 2021 · 7 comments · Fixed by #183
Open
2 of 10 tasks

Top half of Fab TabBarItem is not clickable #76

kazo0 opened this issue Oct 27, 2021 · 7 comments · Fixed by #183
Labels
control/tabbar kind/bug Something isn't working

Comments

@kazo0
Copy link
Contributor

kazo0 commented Oct 27, 2021

Blocked by unoplatform/uno#7393

Current behavior

Given a MaterialBottomTabBar with with one of the Items using the MaterialFabTabBarItemStyle, the translated button is only clickable for the portion of the FAB that is still "inside" the TabBar itself.

Expected behavior

Entire FAB should be clickable

How to reproduce it (as minimally and precisely as possible)

Environment

Nuget Package:

Package Version(s):

Affected platform(s):

  • iOS
  • Android
  • WebAssembly
  • WebAssembly renders for Xamarin.Forms
  • Windows
  • Build tasks

Visual Studio:

  • 2017 (version: )
  • 2019 (version: )
  • for Mac (version: )

Relevant plugins:

  • Resharper (version: )

Anything else we need to know?

@kazo0 kazo0 added kind/bug Something isn't working triage/untriaged Indicates an issue requires triaging or verification. labels Oct 27, 2021
@agneszitte agneszitte self-assigned this Nov 3, 2021
@agneszitte
Copy link
Contributor

I will verify if we don't have another solution / workaround for this issue

@kazo0
Copy link
Contributor Author

kazo0 commented Aug 11, 2022

Reopened by #286

@kazo0 kazo0 reopened this Aug 11, 2022
@agneszitte
Copy link
Contributor

Reopened by #286

@kazo0 this can be closed again right, as #286 is now closed right?

@agneszitte
Copy link
Contributor

@kazo0 maybe you can take a look at this one and check the status of this issue please

@Youssef1313
Copy link
Member

@agneszitte-nventive I can confirm it's still not clickable :'(

@Youssef1313
Copy link
Member

@agneszitte-nventive It looks like the workaround you added in #183 no longer exists. Is it possible to re-add it for the current v2 styles?

@kazo0
Copy link
Contributor Author

kazo0 commented Mar 18, 2023

@Youssef1313 I believe that the old workaround was the cause of this issue: #273

So we decided the top half of the FAB being unclickable was the lesser of two evils :(

Maybe if we layered the TabBar on top of the rest of the page content we wouldn't get this ugly visual bug, but I'm not sure if it would cause problems with touches not falling through to the content underneath

@Xiaoy312 Xiaoy312 added control/tabbar and removed triage/untriaged Indicates an issue requires triaging or verification. labels Apr 28, 2023
@agneszitte agneszitte removed their assignment Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
control/tabbar kind/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants