Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Chip] re-align with figma design #993

Closed
Xiaoy312 opened this issue Jan 11, 2024 · 9 comments · Fixed by #1020
Closed

[Chip] re-align with figma design #993

Xiaoy312 opened this issue Jan 11, 2024 · 9 comments · Fixed by #1020
Assignees
@Xiaoy312
Labels
control/chip-chipgroup kind/bug Something isn't working

Comments

@Xiaoy312
Copy link
Contributor

Xiaoy312 commented Jan 11, 2024 •
edited
Loading

Current behavior

image

Expected behavior

image
https://www.figma.com/file/trM3i5qUPmFBcnxWXXmnuF/Uno-Platform-Material-Toolkit?type=design&node-id=4215-68197&mode=design&t=WgRALqyEbPK8ROAr-0

the check-glyph should not be part of the control,
but the user can decide to add them with the icon property:
image
^ and, they are definitely not associated with the IsChecked state
@Xiaoy312 Xiaoy312 added kind/bug Something isn't working control/chip-chipgroup labels Jan 11, 2024
@Xiaoy312 Xiaoy312 self-assigned this Jan 11, 2024
@Xiaoy312
Copy link
Contributor Author

pending approval

@Xiaoy312
Copy link
Contributor Author

ready for pr branch: https://github.com/unoplatform/uno.toolkit.ui/tree/dev/xygu/20240111/chip-check-glyph-removal

@agneszitte
Copy link
Contributor

(cc @NVLudwig, @iurycarlos)

@NVLudwig
Copy link

Would docs need an update as well?

@Xiaoy312
Copy link
Contributor Author

Xiaoy312 commented Jan 19, 2024 •
edited
Loading

the question first, is do we agree to move forward with this change?

@NVLudwig
Copy link

@Xiaoy312 From me it's: Yes
@iurycarlos
@kazo0

@iurycarlos
Copy link
Contributor

iurycarlos commented Jan 24, 2024 •
edited
Loading

Didn't manifest before as i thought it was an adm decision. If my vote counts, i'm with Ludwig.

@kazo0
Copy link
Contributor

kazo0 commented Jan 24, 2024

@Xiaoy312 I am good with it, let's do it :)

@kazo0 kazo0 mentioned this issue Jan 31, 2024
Merged
@NVLudwig
Copy link

NVLudwig commented Feb 2, 2024

FYI @carldebilly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Xiaoy312 Xiaoy312

Labels
control/chip-chipgroup kind/bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(chip): remove check-glyph unoplatform/uno.toolkit.ui
5 participants
@Xiaoy312 @kazo0 @iurycarlos @agneszitte @NVLudwig