Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Implement Badge for TabBarItem #296

Merged
merged 1 commit into from
Aug 29, 2022
Merged

feat: Implement Badge for TabBarItem #296

merged 1 commit into from
Aug 29, 2022

Conversation

agneszitte
Copy link
Contributor

@agneszitte agneszitte commented Aug 26, 2022 •
edited
Loading

GitHub Issue (If applicable): #274

PR Type

What kind of change does this PR introduce?

  • Feature

Description

Implement Badge for TabBarItem
image

  • BadgeVisibility property to make the badge visible
  • If the BadgeValue property has a value the Large badge will be visible, if not the small badge will be visible instead (similar to the InfoBadge behavior).

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Docs have been added/updated which fit documentation template. (for bug fixes / features)
  • Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Wasm UI Tests are not showing unexpected any differences. Validate PR Screenshots Compare Test Run results.
  • Contains NO breaking changes
  • Updated the Release Notes
  • Associated with an issue (GitHub or internal)

Other information

This implementation can be replaced when InfoBadge will be available in WinUI3
(cf. microsoft/microsoft-ui-xaml#7001)
See this commit for the implementation: c935919
(Related Branch: dev/agzi/I274-InfoBadgeImplementationForTBI)

@github-actions
Copy link

github-actions bot commented Aug 26, 2022 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-296.eastus2.azurestaticapps.net

@agneszitte agneszitte linked an issue Aug 29, 2022 that may be closed by this pull request
Add Badge Property to TabBarItem #274
Closed
@agneszitte agneszitte requested a review from kazo0 August 29, 2022 18:18
@github-actions
Copy link

github-actions bot commented Aug 29, 2022 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-296.eastus2.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Aug 29, 2022 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-296.eastus2.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Aug 29, 2022 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-296.eastus2.azurestaticapps.net

@agneszitte agneszitte enabled auto-merge (squash) August 29, 2022 20:09
@github-actions
Copy link

github-actions bot commented Aug 29, 2022 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-296.eastus2.azurestaticapps.net

@agneszitte agneszitte merged commit 33432e4 into main Aug 29, 2022
@agneszitte agneszitte deleted the dev/agzi/I274 branch August 29, 2022 20:54
@agneszitte agneszitte restored the dev/agzi/I274 branch January 27, 2023 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xiaoy312 Xiaoy312 Xiaoy312 approved these changes

@jeromelaban jeromelaban Awaiting requested review from jeromelaban

@kazo0 kazo0 Awaiting requested review from kazo0

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Badge Property to TabBarItem
3 participants
@agneszitte @Xiaoy312 @kazo0