Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wasm/skia.gtk/macOS] ISupportIncrementalLoading support #5763

Closed
3 of 12 tasks
Xiaoy312 opened this issue Apr 15, 2021 · 4 comments · Fixed by #8114
Closed
3 of 12 tasks

[wasm/skia.gtk/macOS] ISupportIncrementalLoading support #5763

Xiaoy312 opened this issue Apr 15, 2021 · 4 comments · Fixed by #8114
Assignees
@Xiaoy312
Labels
area/listview 📃 Categorizes an issue or PR as relevant to the ListView control difficulty/medium 🤔 Categorizes an issue for which the difficulty level is reachable with a good understanding of WinUI kind/enhancement New feature or request project/items 🧾 Categorizes an issue or PR as relevant to items (ItemsControl, ItemsRepeater, ...)

Comments

@Xiaoy312
Copy link
Contributor

What would you like to be added:

ListView support for ISupportIncrementalLoading

Why is this needed:

For infinite-scrolling.

For which Platform:

  • iOS
  • Android
  • WebAssembly
  • WebAssembly renderers for Xamarin.Forms
  • macOS
  • Skia
    • WPF
    • GTK (Linux)
    • Tizen
  • Windows
  • Build tasks
  • Solution Templates

Anything else we need to know?
@Xiaoy312 Xiaoy312 added kind/enhancement New feature or request triage/untriaged Indicates an issue requires triaging or verification difficulty/tbd Categorizes an issue for which the difficulty level needs to be defined. labels Apr 15, 2021
@jeromelaban jeromelaban added area/listview 📃 Categorizes an issue or PR as relevant to the ListView control project/items 🧾 Categorizes an issue or PR as relevant to items (ItemsControl, ItemsRepeater, ...) difficulty/medium 🤔 Categorizes an issue for which the difficulty level is reachable with a good understanding of WinUI and removed difficulty/tbd Categorizes an issue for which the difficulty level needs to be defined. triage/untriaged Indicates an issue requires triaging or verification labels Apr 19, 2021
@jeromelaban
Copy link
Member

@davidjohnoliver wasn't this supported in wasm ?

@davidjohnoliver
Copy link
Contributor

@davidjohnoliver wasn't this supported in wasm ?

Nope:

uno/src/Uno.UI/UI/Xaml/Controls/ListViewBase/ListViewBase.managed.cs

Lines 73 to 76 in 3b86bd7

private void TryLoadMoreItems()
{
//TODO: ISupportIncrementalLoading
}

@davidjohnoliver
Copy link
Contributor

It's a pretty easy one though.

@jeromelaban jeromelaban mentioned this issue May 13, 2021
Closed
14 tasks
@jeromelaban jeromelaban changed the title [wasm/skia.gtk] ISupportIncrementalLoading support [wasm/skia.gtk/macOS] ISupportIncrementalLoading support May 13, 2021
@jeromelaban jeromelaban mentioned this issue Oct 18, 2021
Closed
@Xiaoy312
Copy link
Contributor Author

related: #234

@Xiaoy312 Xiaoy312 mentioned this issue Feb 16, 2022
Merged
6 tasks
@jeromelaban jeromelaban mentioned this issue Apr 25, 2022
Open
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Xiaoy312 Xiaoy312

Labels
area/listview 📃 Categorizes an issue or PR as relevant to the ListView control difficulty/medium 🤔 Categorizes an issue for which the difficulty level is reachable with a good understanding of WinUI kind/enhancement New feature or request project/items 🧾 Categorizes an issue or PR as relevant to items (ItemsControl, ItemsRepeater, ...)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(ListView): incremental loading support for skia/wasm unoplatform/uno
3 participants
@Xiaoy312 @jeromelaban @davidjohnoliver