From 43635aa02c4d0832e248384adc4ea4e53ce400cf Mon Sep 17 00:00:00 2001 From: Ramez Ragaa Date: Wed, 20 Sep 2023 13:33:26 +0300 Subject: [PATCH] chore!: Remove SetterBase.set_Property --- doc/articles/migrating-from-previous-releases.md | 3 +++ src/Uno.UI/UI/Xaml/Setter.Generic.cs | 2 -- src/Uno.UI/UI/Xaml/SetterBase.cs | 9 --------- 3 files changed, 3 insertions(+), 11 deletions(-) diff --git a/doc/articles/migrating-from-previous-releases.md b/doc/articles/migrating-from-previous-releases.md index 2dbe7a7ceacd..c665cdb89f2c 100644 --- a/doc/articles/migrating-from-previous-releases.md +++ b/doc/articles/migrating-from-previous-releases.md @@ -123,6 +123,9 @@ This change has no effect on Controls behavior. #### Change `RenderSurfaceType` namespace There used two be two `RenderSurfaceType`s, `Uno.UI.Runtime.Skia.RenderSurfaceType` (for Gtk) and `Uno.UI.Skia.RenderSurfaceType` (for Skia). They are now `Uno.UI.Runtime.Skia.Gtk.RenderSurfaceType` and `Uno.UI.Runtime.Skia.Wpf.RenderSurfaceType` respectively. +#### Rmove `SetterBase.set_Property` +This method was only present for binary backward compatibility with `Setter`. Use `Setter.Property` or `Setter.Property` instead + #### `Panel`s no longer measure or arrange any children in `MeasureOverride` or `ArrangeOverride`, respectively `Panel`s used to measure and arrange the first child in `MeasureOverride` or `ArrangeOverride`, respectively. This is no longer the case. Now, to match WinUI, `Panel`s just return an empty size in `MeasureOverride`, and the `finalSize` as is in `ArrangeOverride`. You should override these layout-override methods in `Panel`-derived subclasses instead. diff --git a/src/Uno.UI/UI/Xaml/Setter.Generic.cs b/src/Uno.UI/UI/Xaml/Setter.Generic.cs index 64550bf06629..3049afe60e22 100644 --- a/src/Uno.UI/UI/Xaml/Setter.Generic.cs +++ b/src/Uno.UI/UI/Xaml/Setter.Generic.cs @@ -26,8 +26,6 @@ public Setter(string property, Action action) /// public string Property { get; set; } - internal override void OnStringPropertyChanged(string name) => Property = name; - internal override void ApplyTo(DependencyObject o) { if (!(o is T)) diff --git a/src/Uno.UI/UI/Xaml/SetterBase.cs b/src/Uno.UI/UI/Xaml/SetterBase.cs index 98b37e12ed68..ceeec67daa92 100644 --- a/src/Uno.UI/UI/Xaml/SetterBase.cs +++ b/src/Uno.UI/UI/Xaml/SetterBase.cs @@ -15,15 +15,6 @@ internal SetterBase() internal abstract void ApplyTo(DependencyObject o); - /// - /// This method is present for binary backward compatibility with . - /// Use or instead. - /// - [EditorBrowsable(EditorBrowsableState.Never)] - public void set_Property(string name) => OnStringPropertyChanged(name); - - internal virtual void OnStringPropertyChanged(string name) { } - partial void OnDataContextChangedPartial(DependencyPropertyChangedEventArgs e) { this.Log().Debug("SetterBase.DataContextChanged");