Skip to content
This repository has been archived by the owner on Jun 2, 2023. It is now read-only.

Recaptcha v3 is a bad choice for this type of app #320

Closed
xxbiohazrdxx opened this issue Aug 21, 2019 · 16 comments · Fixed by #372
Closed

Recaptcha v3 is a bad choice for this type of app #320

xxbiohazrdxx opened this issue Aug 21, 2019 · 16 comments · Fixed by #372
Assignees

Comments

@xxbiohazrdxx
Copy link

Is your feature request related to a problem? Please describe.
Recaptcha v3 is more reliable for large, complex websites/apps. It uses analytics on as many pages as possible to track a user's interactions with the site over a long period of time. A small app that consists of a single page and that is rarely visited by a user and only for a few seconds is not enough data for Recaptcha v3 to be reliable.

Without a fallback to select images, etc. Recaptcha v3 fails for me frequently in PassCore v4

Describe the solution you'd like
Re-add support for Recaptcha v2

@geoperez
Copy link
Member

@Serk352 there is a way to support both versions in the React component that you used?

@Serk352
Copy link
Contributor

Serk352 commented Aug 26, 2019

@geoperez no, the component was developed specifically for v3.

@geoperez
Copy link
Member

OK, anyway, let's keep this issue open and see if we can change it later.

@geoperez
Copy link
Member

geoperez commented Oct 6, 2019

@Serk352 can you give it a chance to this issue this week?

@Serk352
Copy link
Contributor

Serk352 commented Oct 6, 2019

@geoperez sure, I will.

@geoperez
Copy link
Member

I need to release a new version.

@geoperez geoperez reopened this Oct 14, 2019
@geoperez
Copy link
Member

@xxbiohazrdxx can you verify the new implementation?

@Serk352 Serk352 removed their assignment Oct 29, 2019
@dragoangel
Copy link

dragoangel commented Oct 31, 2019

Hi,
@geoperez getting Could not verify you are not a robot after update from 3 to 4 version all time. So I was forced to remove Recaptcha.
I get status code 400 from :method: POST at :path: /api/password with request payload:
CurrentPassword: "password"
NewPassword: "password2"
NewPasswordVerify: "password2"
Recaptcha: ""
Username: "user"
So it seems to be broken at frontend part due method send null Recaptcha, when at same time I was Recaptcha activated without any errors.
P.S. compiled from source from 4.2.1 release with dotnet-sdk-3.0.100-win-x64 and node-v12.13.0-x64 for
dotnet publish --configuration Release --runtime linux-x64 /p:PASSCORE_PROVIDER=LDAP

@Serk352
Copy link
Contributor

Serk352 commented Nov 6, 2019

Hi @dragoangel, there's a new release that fixed this issue, please try it.

@messiah109501
Copy link

messiah109501 commented Nov 7, 2019

I had same issue as dragoangel with the captcha v2 verification. Just updated to 4.2.2 and issue remains for me.

@dragoangel
Copy link

@Serk352 ok will try 4.2.2

@dragoangel
Copy link

dragoangel commented Nov 12, 2019

@Serk352 build from 4.2.2 sources (and master branch):
GET https://hostname/api/password net::ERR_ABORTED 500
Lead to page loading endless, dotnet fail:
fail: Microsoft.AspNetCore.Server.Kestrel[13] Connection id "0HLR7BQIQSBNP", Request id "0HLR7BQIQSBNP:00000001": An unhandled exception was thrown by the application. System.InvalidOperationException: Unable to resolve service for type 'Microsoft.Extensions.Logging.ILogger' while attempting to ac tivate 'Zyborg.PassCore.PasswordProvider.LDAP.LdapPasswordChangeProvider'. at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteFactory.CreateArgumentCallSites(Type serviceType, Type implem entationType, CallSiteChain callSiteChain, ParameterInfo[] parameters, Boolean throwIfCallSiteNotFound) at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteFactory.CreateConstructorCallSite(ResultCache lifetime, Type serviceType, Type implementationType, CallSiteChain callSiteChain) at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteFactory.TryCreateExact(ServiceDescriptor descriptor, Type ser viceType, CallSiteChain callSiteChain, Int32 slot) at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteFactory.TryCreateExact(Type serviceType, CallSiteChain callSi teChain) at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteFactory.CreateCallSite(Type serviceType, CallSiteChain callSi teChain) at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteFactory.<>c__DisplayClass7_0.<GetCallSite>b__0(Type type) at System.Collections.Concurrent.ConcurrentDictionary2.GetOrAdd(TKey key, Func2 valueFactory) at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteFactory.GetCallSite(Type serviceType, CallSiteChain callSiteC hain) at Microsoft.Extensions.DependencyInjection.ServiceLookup.ServiceProviderEngine.CreateServiceAccessor(Type serviceType) at System.Collections.Concurrent.ConcurrentDictionary2.GetOrAdd(TKey key, Func2 valueFactory) at Microsoft.Extensions.DependencyInjection.ServiceLookup.ServiceProviderEngine.GetService(Type serviceType, ServiceProviderEng ineScope serviceProviderEngineScope) at Microsoft.Extensions.DependencyInjection.ServiceLookup.ServiceProviderEngineScope.GetService(Type serviceType) at Microsoft.Extensions.DependencyInjection.ActivatorUtilities.GetService(IServiceProvider sp, Type type, Type requiredBy, Bool ean isDefaultParameterRequired) at lambda_method(Closure , IServiceProvider , Object[] ) at Microsoft.AspNetCore.Mvc.Controllers.ControllerActivatorProvider.<>c__DisplayClass4_0.<CreateActivator>b__0(ControllerContex t controllerContext) at Microsoft.AspNetCore.Mvc.Controllers.ControllerFactoryProvider.<>c__DisplayClass5_0.<CreateControllerFactory>g__CreateContro ller|0(ControllerContext controllerContext) at Microsoft.AspNetCore.Mvc.Infrastructure.ControllerActionInvoker.Next(State& next, Scope& scope, Object& state, Boolean& isCo mpleted) at Microsoft.AspNetCore.Mvc.Infrastructure.ControllerActionInvoker.InvokeInnerFilterAsync() --- End of stack trace from previous location where exception was thrown --- at Microsoft.AspNetCore.Mvc.Infrastructure.ResourceInvoker.<InvokeFilterPipelineAsync>g__Awaited|19_0(ResourceInvoker invoker, Task lastTask, State next, Scope scope, Object state, Boolean isCompleted) at Microsoft.AspNetCore.Mvc.Infrastructure.ResourceInvoker.<InvokeAsync>g__Logged|17_1(ResourceInvoker invoker) at Microsoft.AspNetCore.Routing.EndpointMiddleware.<Invoke>g__AwaitRequestTask|6_0(Endpoint endpoint, Task requestTask, ILogger logger) at Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Http.HttpProtocol.ProcessRequests[TContext](IHttpApplication1 application )
`
at same time work 4.2.1, I think it related to "Improve logging in LDAP Provider"

@avoit
Copy link

avoit commented Nov 17, 2019

Hi All,

Everything is working except the Recaptcha part. I keep getting could not verify you are not a robot error. Anything specific I need to check? I used V2 & V3 with the correct site and secret keys. I am using version PassCore422 (latest release)

@geoperez
Copy link
Member

@Serk352 can you take a look in the Recaptcha issue?

@stale
Copy link

stale bot commented Jan 16, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix Problem, or not; this won't be fixed here at least. label Jan 16, 2020
@stale stale bot removed the wontfix Problem, or not; this won't be fixed here at least. label Jan 17, 2020
@dragoangel
Copy link

dragoangel commented May 19, 2020

@geoperez Hi, after update to 4.2.3 I can successfully build app for linux. I had issues with nuget packages via npm install cli, but via Visual Studio 2019 Community it works. Doesn't know why exactly. With new version ReCaptcha v2 work fine, thank you

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants