Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

abaddon does not build with -DENABLE_RNNOISE=OFF #334

Closed
techflashYT opened this issue Oct 30, 2024 · 0 comments · Fixed by #335
Closed

abaddon does not build with -DENABLE_RNNOISE=OFF #334

techflashYT opened this issue Oct 30, 2024 · 0 comments · Fixed by #335

Comments

@techflashYT
Copy link
Contributor

With rnnoise support disabled (targetting a Linux distro that lacks the package, as well all of the CPUs that this build will be running on are far too slow to handle it), abaddon does not build successfully, I get the following error:

[ 95%] Building CXX object CMakeFiles/abaddon.dir/src/windows/profilewindow.cpp.o
[ 95%] Building CXX object CMakeFiles/abaddon.dir/src/windows/threadswindow.cpp.o
[ 96%] Building CXX object CMakeFiles/abaddon.dir/src/windows/voice/voicewindow.cpp.o
/home/techflash/archpower-extra-pkgs/abaddon/src/abaddon/src/windows/voice/voicewindow.cpp: In constructor ‘VoiceWindow::VoiceWindow(Snowflake)’:
/home/techflash/archpower-extra-pkgs/abaddon/src/abaddon/src/windows/voice/voicewindow.cpp:118:42: error: ‘class AudioManager’ has no member named ‘GetSuppressNoise’
  118 |     m_noise_suppression.set_active(audio.GetSuppressNoise());
      |                                          ^~~~~~~~~~~~~~~~
/home/techflash/archpower-extra-pkgs/abaddon/src/abaddon/src/windows/voice/voicewindow.cpp: In lambda function:
/home/techflash/archpower-extra-pkgs/abaddon/src/abaddon/src/windows/voice/voicewindow.cpp:120:35: error: ‘class AudioManager’ has no member named ‘SetSuppressNoise’
  120 |         Abaddon::Get().GetAudio().SetSuppressNoise(m_noise_suppression.get_active());
      |                                   ^~~~~~~~~~~~~~~~
make[2]: *** [CMakeFiles/abaddon.dir/build.make:1549: CMakeFiles/abaddon.dir/src/windows/voice/voicewindow.cpp.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [CMakeFiles/Makefile2:122: CMakeFiles/abaddon.dir/all] Error 2
make: *** [Makefile:136: all] Error 2
make: Leaving directory '/home/techflash/archpower-extra-pkgs/abaddon/src/build'

I have a small patch that may fix this issue. If it works, I'll submit a PR fixing it shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant