Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issueCount doesn't work on "non-standard" GH issue URLs #607

Open
aph3rson opened this issue Apr 30, 2017 · 2 comments
Open

issueCount doesn't work on "non-standard" GH issue URLs #607

aph3rson opened this issue Apr 30, 2017 · 2 comments

Comments

@aph3rson
Copy link
Contributor

Right now, the issueCount function relies on the link attribute for each project. However, many of these links aren't in a standard format, and can't guarantee that additional options are being passed in this URL (both of which cause issueCount to not return a count).

Perhaps it might be better to update the function to compose its own URL to check against the API, by using the site and up-for-grabs/name attributes - that way, projects can link to a custom filter if need be, but the website will still render a count for viewers (albeit possibly inaccurately).

Related to #605.

@aph3rson
Copy link
Contributor Author

aph3rson commented May 10, 2017

GitHub's Search API allows for 10x as many unauthenticated requests, as well as supporting searches for multiple labels (incl. negation), organizations, and exposing a single count in the JSON response (without dealing with pagination - returns up to 1000 responses in one query). It might be prudent to move to using this Search API, instead of using the current Issues API.

edit: x-ref #567 (comment)

@stale

This comment has been minimized.

@stale stale bot added the wontfix label Oct 16, 2019
@shiftkey shiftkey removed the wontfix label Oct 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants