Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ubuntu-20.04 machine type for provider-ci/lint job #163

Merged
merged 1 commit into from
Nov 16, 2023

Conversation

sergenyalcin
Copy link
Member

@sergenyalcin sergenyalcin commented Nov 16, 2023

Description of your changes

Use ubuntu-20.04 machine type for provider-ci/lint job.

We observed some issues in the lint job on the provider-aws repo. In this issue, the users also report a similar problem, and they suggest downgrading the OS version to ubuntu-20.04.

I have:

  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

Signed-off-by: Sergen Yalçın <yalcinsergen97@gmail.com>
Copy link
Contributor

@ulucinar ulucinar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sergenyalcin, lgtm. Could you please also add a pointer to the issue you found and mentions the issues with ubuntu-22.04.

@sergenyalcin
Copy link
Member Author

Thanks @sergenyalcin, lgtm. Could you please also add a pointer to the issue you found and mentions the issues with ubuntu-22.04.

Added to description.

@sergenyalcin sergenyalcin merged commit 9010c32 into upbound:main Nov 16, 2023
6 checks passed
@sergenyalcin sergenyalcin deleted the use-ubuntu-20.04 branch November 16, 2023 08:56
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants