Inherit golangci-lint version from build submodule
#829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ytsarev
requested review from
ulucinar,
sergenyalcin and
turkenf
as code owners
* Motivation: golangci-lint base run was freezing on Mac M1 and go1.20.5. * Remove the version override in the Makefile with the comment and consume the latest version from the build * Presumably, it was a fix around consume a lot of memory on go1.20rc3 golangci/golangci-lint#3470 helped in the latest golangci-lint release * Update build submodule to consume upbound/build#238 Signed-off-by: Yury Tsarev <yury@upbound.io>
ytsarev
force-pushed
the
inherit-golanci-lint
branch
from
026e094
to
7b47392
Compare
1 task
mergenci
added a commit
to mergenci/uptest
that referenced
this pull request
Sep 4, 2023
* Shamelessly copy Yury Tsarev's (@ytsarev) following changes to other repos, such as crossplane-contrib/provider-upjet-aws#829: * Motivation: golangci-lint base run was freezing on Mac M1 and go1.20.5. * Remove the version override in the Makefile with the comment and consume the latest version from the build * Presumably, it was a fix around consume a lot of memory on go1.20rc3 consume a lot of memory on go1.20rc3 golangci/golangci-lint#3470 helped in the latest golangci-lint release * Update build submodule to consume upbound/build#238 Signed-off-by: Cem Mergenci <cmergenci@gmail.com>
mergenci
added a commit
to mergenci/uptest
that referenced
this pull request
Sep 4, 2023
Shamelessly copy Yury Tsarev's (@ytsarev) following changes to other repos, such as crossplane-contrib/provider-upjet-aws#829: * Motivation: golangci-lint base run was freezing on Mac M1 and go1.20.5. * Remove the version override in the Makefile with the comment and consume the latest version from the build * Presumably, it was a fix around consume a lot of memory on go1.20rc3 consume a lot of memory on go1.20rc3 golangci/golangci-lint#3470 helped in the latest golangci-lint release * Update build submodule to consume upbound/build#238 Signed-off-by: Cem Mergenci <cmergenci@gmail.com>
mergenci
added a commit
to mergenci/uptest
that referenced
this pull request
Sep 4, 2023
Shamelessly copy Yury Tsarev's (@ytsarev) following changes to other repos, such as crossplane-contrib/provider-upjet-aws#829: * Motivation: golangci-lint base run was freezing on Mac M1 and go1.20.5. * Remove the version override in the Makefile with the comment and consume the latest version from the build * Presumably, it was a fix around consume a lot of memory on go1.20rc3 consume a lot of memory on go1.20rc3 golangci/golangci-lint#3470 helped in the latest golangci-lint release * Update build submodule to consume upbound/build#238 Signed-off-by: Cem Mergenci <cmergenci@gmail.com>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
rm -rf .cachemake reviewable