Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the options to define revisionHistoryLimit for Crossplane and RBAC manager #484

Closed

Conversation

pierluigilenoci
Copy link

@pierluigilenoci pierluigilenoci commented Oct 16, 2024

Description of your changes

Added the options to define revisionHistoryLimit for Crossplane and RBAC manager.
Related to crossplane/crossplane#6013

I have:

  • Read and followed Upbound's contribution process.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR, as appropriate.

How has this code been tested

helm lint .
helm template .

@pierluigilenoci
Copy link
Author

@turkenf, could you please take a look?

…BAC manager

Signed-off-by: Pierluigi Lenoci <pierluigi.lenoci@gmail.com>
@jeanduplessis
Copy link
Contributor

@pierluigilenoci I will close this PR here as we will consume the change from upstream XP after the PR you opened there, crossplane/crossplane#6013, is merged.

@pierluigilenoci pierluigilenoci deleted the revisionHistoryLimit branch October 16, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants