From a0b442e2b3b2262fd7fffa355e79912e84248a0f Mon Sep 17 00:00:00 2001
From: yoshikazusawa <883514+yoshikazusawa@users.noreply.github.com>
Date: Wed, 29 May 2024 23:47:39 +0900
Subject: [PATCH] Treats POSIX character class [:digit:]

https://perldoc.perl.org/perlrecharclass
> digit  Any decimal digit (e.g., [0-9]), equivalent to "\d".
---
 .../Plicease/ProhibitUnicodeDigitInRegexp.pm  | 15 +++++----
 t/Plicease/ProhibitUnicodeDigitInRegexp.run   | 31 ++++++++++++++++++-
 2 files changed, 39 insertions(+), 7 deletions(-)

diff --git a/lib/Perl/Critic/Policy/Plicease/ProhibitUnicodeDigitInRegexp.pm b/lib/Perl/Critic/Policy/Plicease/ProhibitUnicodeDigitInRegexp.pm
index ebdfe63..8d49c4d 100644
--- a/lib/Perl/Critic/Policy/Plicease/ProhibitUnicodeDigitInRegexp.pm
+++ b/lib/Perl/Critic/Policy/Plicease/ProhibitUnicodeDigitInRegexp.pm
@@ -23,16 +23,19 @@ code:
 
 =head1 DESCRIPTION
 
-The character class C<\d> in a regular expression matches all unicode digit character, which
+The character class C<\d> (also the POSIX character class C<[:digit:]>) in a regular expression matches all unicode digit character, which
 might not be what you expect if you are testing if a string can be used as a number in Perl.
 Instead use either C<[0-9]>, or if you are on Perl 5.14 or better you can use the C</a>
 modifier.  This policy allows C<\d> in expressions with an explicit C</u> modifier (normally
 on by default), as it indicates that the code is expecting Unicode semantics, including Unicode
 digits.
 
- /\d/;      # not ok
- /\d/a;     # ok
- /\d/u;     # ok
+ /\d/;           # not ok
+ /[[:digit:]]/;  # not ok
+ /\d/a;          # ok
+ /\d/u;          # ok
+ /[[:digit:]]/a; # ok
+ /[[:digit:]]/u; # ok
  /[0-9]/;   # ok
 
 =head1 AFFILIATION
@@ -64,7 +67,7 @@ This policy doesn't take into account using the L<re> pragma.
 =cut
 
 use constant DESC => 'Using non-ASCII \d';
-use constant EXPL => 'The character class \d matches non-ASCII unicode digits.  ' .
+use constant EXPL => 'The character class \d (also the POSIX character class [:digit:]) matches non-ASCII unicode digits.  ' .
                      'Use [0-9] or the /a modifier (Perl 5.14+) instead.';
 
 sub supported_parameters { ()                                        }
@@ -92,7 +95,7 @@ sub violates
   return unless $ccs;
   foreach my $cc (@$ccs)
   {
-    next if $cc->content ne '\\d';
+    next if ($cc->content ne '\\d' && $cc->content ne '[:digit:]');
     return $self->violation( DESC, EXPL, $elem );
   }
 
diff --git a/t/Plicease/ProhibitUnicodeDigitInRegexp.run b/t/Plicease/ProhibitUnicodeDigitInRegexp.run
index 2ec3ed9..f9c40ca 100644
--- a/t/Plicease/ProhibitUnicodeDigitInRegexp.run
+++ b/t/Plicease/ProhibitUnicodeDigitInRegexp.run
@@ -4,6 +4,12 @@
 
 /\d/;
 
+## name RexExpWithPosixDigitClass
+## failures 1
+## cut
+
+/[[:digit:]]/;
+
 ## name RexExpSubWithSlashD
 ## failures 1
 ## cut
@@ -18,12 +24,27 @@ use re '/a';
 
 /\d/;
 
+## name GlobalDoesntSaveYouAgain
+## failures 1
+## cut
+
+use re '/a';
+
+/[[:digit:]]/;
+
+
 ## name QuoteLikeRegexpWithSlashD
 ## failures 1
 ## cut
 
 qr/\d//;
 
+## name QuoteLikeRegexpWithPosixDigitClass
+## failures 1
+## cut
+
+qr/[[:digit:]]//;
+
 ## name RegExpWithDifferentDelim
 ## failures 3
 ## cut
@@ -32,6 +53,14 @@ m{\d};
 s!\d!!;
 qr#\d#;
 
+## name RegExpWithDifferentDelim
+## failures 3
+## cut
+
+m{[[:digit:]]};
+s![[:digit:]]!!;
+qr#[[:digit:]]#;
+
 ## name Transliterate
 ## failures 0
 ## cut
@@ -66,4 +95,4 @@ tr/\d//;
 ## failures 0
 ## cut
 
-/foo/;
\ No newline at end of file
+/foo/;