This repository has been archived by the owner on Apr 15, 2020. It is now read-only.
Added coverage report #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
oed
force-pushed
the
feature/148737257-coverage-report
branch
from
f3f7ebd
to
091c0ec
Compare
|
Some things I found that might be worth updating in the
|
localredhead
reviewed
Aug 3, 2017
naterush
reviewed
Aug 8, 2017
| @@ -0,0 +1,158 @@ | |||
| var addSorting = (function () { | |||
There was a problem hiding this comment.
Hm. Ok, just to clarify and make sure I understand correctly, the .html files above are essentially ways of displaying the coverage of the contracts. Is this file for helping with that task also?
naterush
reviewed
Aug 8, 2017
| @@ -0,0 +1,158 @@ | |||
| var addSorting = (function () { | |||
There was a problem hiding this comment.
Hmm - is this a file repeat? Not sure I totally follow what is happening here :)
There was a problem hiding this comment.
all files in the coverage folder are auto generated :)
naterush
approved these changes
Aug 8, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a coverage report using solidity-coverage. It also adds some additional tests.
The coverage report will be availiable on https://uport-project.github.io/uport-identity/coverage once this branch is in master. They are also availiable in the
docs/coveragefolder