-
Notifications
You must be signed in to change notification settings - Fork 69
Conversation
f3f7ebd
to
091c0ec
Compare
Some things I found that might be worth updating in the
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - 1 more review please
@@ -0,0 +1,158 @@ | |||
var addSorting = (function () { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm. Ok, just to clarify and make sure I understand correctly, the .html files above are essentially ways of displaying the coverage of the contracts. Is this file for helping with that task also?
@@ -0,0 +1,158 @@ | |||
var addSorting = (function () { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm - is this a file repeat? Not sure I totally follow what is happening here :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all files in the coverage
folder are auto generated :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes to the tests look great. I'm assuming the rest of the changes are the coverage report, which I guess is good too, though I don't know much :)
This PR adds a coverage report using solidity-coverage. It also adds some additional tests.
The coverage report will be availiable on https://uport-project.github.io/uport-identity/coverage once this branch is in master. They are also availiable in the
docs/coverage
folder