Updated meta-tx work #45
Conversation
|
@pelle quick note: I'll get 1. tests working, and 2. update MetaIdentityManager to take into account the recent changes in IdentityManager. Should be pretty simple. I'll update you when ready for reveiw :). Thanks! |
test/txRelay.js
Outdated
|
|
||
| function signPayload(signingAddr, sendingAddr, txRelay, destinationAddress, functionName, | ||
| functionTypes, functionParams, lw, keyFromPw) { | ||
| return new Promise( |
There was a problem hiding this comment.
await could be used in this function instead.
test/txRelay.js
Outdated
|
|
||
| errorThrown = false | ||
|
|
||
| MetaTxRelay.new().then(instance => { |
There was a problem hiding this comment.
using await should work here as well
|
Also: we need to add |
|
@oed changed tests to await. Added files to index.js |
contracts/MetaIdentityManager.sol
Outdated
| } | ||
|
|
||
| modifier onlyOwner(address identity, address sender) { | ||
| if (owners[identity][sender] > 0 && (owners[identity][sender] + userTimeLock) <= now ) _ ; |
There was a problem hiding this comment.
Do we want to use isOwner here?
There was a problem hiding this comment.
Yes, I think this makes sense for clarity. I will update now. Here and in IdentityManager
naterush
force-pushed
the
feature/new-meta-tx
branch
from
fa5bc58
to
e45ce2f
Compare
There was a problem hiding this comment.
LGTM great team work @oed, @naterush and @christianlundkvist
|
Ok, merging! 😃 |
This pull request simplifies the meta-tx pull request dramatically (and contains both the IdentityManager from the MetaIdentityManager). For the write-up, still see here: https://consensys.quip.com/CoClAjSTyBZI