Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for allowlist and/or blocklist jobs #17

Closed
rytswd opened this issue Oct 2, 2021 · 1 comment
Closed

Add support for allowlist and/or blocklist jobs #17

rytswd opened this issue Oct 2, 2021 · 1 comment

Comments

@rytswd
Copy link
Contributor

rytswd commented Oct 2, 2021

This project currently assumes all of the jobs need to pass. It's probably useful to have a whitelist / blacklist feature to suppress some errors that are irrelevant.

@rytswd rytswd changed the title Add support for whitelist and/or blacklist jobs Add support for allowlist and/or blocklist jobs Jun 23, 2022
@rytswd
Copy link
Contributor Author

rytswd commented Jun 24, 2022

Thanks to @tekiflo , "blocklist" (renamed for better inclusivity) has been added with ignored field 🎉

As to "allowlist", there will be a question how "allowlist" + "blocklist" would work together. If defined in both lists, should that be allowed, or blocked?

Merge Gatekeeper aims to be a "simple" solution, which you can simply copy/paste the simple YAML provided in this repo, and you are all set. For some certain scenarios, list of ignored jobs makes perfect sense, and gives the great flexibility of how you deal with Merge Gatekeeper.
With more complexity such as "allowlist" + "blocklist", it can look unnecessarily overwhelming, and without right terminology, it could well be confusing how those configurations should be handled.

The list of "ignored" jobs makes sense perfectly (again, thanks for coming up with that name, @tekiflo ☺️). This is already a great addition, and I will mark this ticket closed. For the "allowlist" setup, I am creating a new ticket separately, so that anyone keen to get that feature added can react to it, and also chime in with what makes most sense for such setup 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant