Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: running isort to organize imports #16

Merged
merged 2 commits into from
May 16, 2024
Merged

feat: running isort to organize imports #16

merged 2 commits into from
May 16, 2024

Conversation

pedroimpulcetto
Copy link
Contributor

@pedroimpulcetto pedroimpulcetto commented May 6, 2024 •
edited
Loading

isort

Running isort to organize imports

  • Include isort as dev dependency
  • Change README to run isort with black
  • Specify isort profile = black to avoid any conflict

isort uses as default:

  1. FUTURE
  2. STDLIB
  3. THIRDPARTY
  4. LOCALFOLDER
  5. FIRSTPARTY

@pedroimpulcetto
Copy link
Contributor Author

can you check, please @MeshanKhosla?

MeshanKhosla
MeshanKhosla approved these changes May 16, 2024
View reviewed changes
Copy link
Contributor

@MeshanKhosla MeshanKhosla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MeshanKhosla MeshanKhosla merged commit 0ba4f80 into upstash:main May 16, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MeshanKhosla MeshanKhosla MeshanKhosla approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pedroimpulcetto @MeshanKhosla