Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop {assertthat} dependency #242

Closed
jameslamb opened this issue Feb 1, 2025 · 0 comments · Fixed by #243
Closed

Drop {assertthat} dependency #242

jameslamb opened this issue Feb 1, 2025 · 0 comments · Fixed by #243
Labels
maintenance miscellaneous maintenance R

Comments

@jameslamb
Copy link
Collaborator

Description

{assertthat} is a strong dependency of this {uptasticsearch}. It's a collection of small functions that provide some syntactic sugar and nice error messages for common assertions.

{uptasticsearch} should drop that dependency.

Benefits of this work

  • reduces the risk of needing to update under thread of CRAN archival if / when {assertthat} is eventually fully abandoned
  • reduces the number of packages that need to be installed to use {uptasticsearch}
  • removes a GPL-3 dependency from {uptasticsearch}, which could be a problem in some environments that are way of copyleft licenses

Acceptance criteria

  • {uptasticsearch} does not depend on {assertthat}

Approach

We have good tests we can trust, try a change and see what happens.

Try to replace these with internal helper functions.

Notes

{assertthat} appears to be abandoned.

@jameslamb jameslamb added maintenance miscellaneous maintenance R labels Feb 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance miscellaneous maintenance R
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant