Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handling of versioning #75

Closed
jameslamb opened this issue Jun 18, 2018 · 2 comments
Closed

handling of versioning #75

jameslamb opened this issue Jun 18, 2018 · 2 comments

Comments

@jameslamb
Copy link
Collaborator

@ngparas comments on #73

since there are also minor changes in scrolling between the versions i'd love if we could pull all the version-specific stuff up higher and configure w/ passing functions instead of putting internal switches like this

IMHO the best way to handle this would be to use an internal R6 object that just holds all of the version specific stuff and have that object get passed around to methods that need it (all internal). But idk...open to suggestions

@jameslamb
Copy link
Collaborator Author

Add R label since using an internal object is already how we handle this in Python.

@jameslamb
Copy link
Collaborator Author

Two years later, the code for #73 is still going strong!

from the blame:

image

Since we're not considering extensions to uptasticsearch and just basically keeping it working, I don't think we're ever going to refactor the internals of the R package like this issue describes. I think this can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant