Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add CreateTxSQLMigrations function #916

Conversation

codeliger
Copy link
Contributor

@codeliger codeliger commented Oct 6, 2023

This PR enables the CreateSQLMigrations function to create transactional sql migration files (.tx.sql)

@codeliger codeliger marked this pull request as draft October 6, 2023 18:20
@codeliger codeliger force-pushed the add-transactional-flag-to-create-sql-migrations branch 4 times, most recently from 6471c12 to 9ee45b2 Compare October 6, 2023 18:36
@codeliger codeliger marked this pull request as ready for review October 6, 2023 18:42
migrate/migrator.go Outdated Show resolved Hide resolved
@vmihailenco vmihailenco added the question Further information is requested label Jan 6, 2024
@codeliger codeliger force-pushed the add-transactional-flag-to-create-sql-migrations branch from 9ee45b2 to 5b363ab Compare January 7, 2024 17:47
Allow CreateSQLMigrations to use .tx.sql and use a transactional template
@codeliger codeliger force-pushed the add-transactional-flag-to-create-sql-migrations branch from 5b363ab to 8115752 Compare January 7, 2024 17:49
@codeliger codeliger requested a review from vmihailenco January 7, 2024 17:57
@codeliger codeliger changed the title add transactional flag to CreateSQLMigrations add CreateTxSQLMigrations function Jan 7, 2024
@vmihailenco
Copy link
Member

Thank you 👍

@vmihailenco vmihailenco merged commit c68ec7c into uptrace:master Jan 10, 2024
3 checks passed
@codeliger codeliger deleted the add-transactional-flag-to-create-sql-migrations branch January 10, 2024 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants