Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expression body parser #162

Merged
merged 4 commits into from
Aug 13, 2023
Merged

Expression body parser #162

merged 4 commits into from
Aug 13, 2023

Conversation

ivojawer
Copy link
Contributor

@ivojawer ivojawer commented Jul 29, 2023 •
edited by PalumboN
Loading

Fix uqbar-project/wollok-lsp-ide#83
Fix #158

Ahora los metodos de consulta pueden marcar su "body" como una sentencia malformada

Tambien arregla un typo de las validations que fixea #158

Tests: uqbar-project/wollok-language#161

@ivojawer ivojawer requested a review from PalumboN July 29, 2023 16:44
@PalumboN PalumboN mentioned this pull request Jul 30, 2023
Merged
@asanzo
Copy link
Contributor

asanzo commented Jul 30, 2023

🤯 👏 👍 👏 👏 👏 👏

@PalumboN
Copy link
Contributor

El CI dice que se rompió un test del parser: should parse annotated subnodes within expression bodies

@PalumboN PalumboN changed the base branch from master to shouldInitializeAllAttributes August 12, 2023 12:41
@PalumboN PalumboN merged commit 15e1031 into shouldInitializeAllAttributes Aug 13, 2023
2 checks passed
@PalumboN PalumboN deleted the expression-body-parser branch August 13, 2023 17:09
@PalumboN PalumboN mentioned this pull request Aug 13, 2023
Closed
@PalumboN PalumboN mentioned this pull request Aug 20, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PalumboN PalumboN PalumboN approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@ivojawer @asanzo @PalumboN