fix: update Map event listeners on prop changes #349
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When updating the event listener props, the MapGL component does not propagate these changes to the underlying Mapbox instance. This makes it impossible to use state inside, for example, the
onClick
event handler as it will be bound to the first render. It also makes it impossible to remove event handlers dynamically.This PR updates any event listeners that has changed in a similar way to how
componentDidMount
applies the initial listeners.Fixes #324