-
-
Notifications
You must be signed in to change notification settings - Fork 454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(graphcache): Improve separation of API and owned data #3165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kitten
changed the title
Fix/owned data
fix(graphcache): Improve separation of API and owned data
Apr 19, 2023
kitten
force-pushed
the
fix/owned-data
branch
2 times, most recently
from
April 19, 2023 15:32
300c633
to
0e6d901
Compare
This was referenced Apr 19, 2023
JoviDeCroock
approved these changes
Apr 20, 2023
Merged
3 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3160
Summary
This prevents us from:
__typename
to be applied to output data by defaultIn short, we don't differentiate in the
cacheExchange
whether we're passingquery()
previous Graphcache data or API data. This data is then used to diff against the new result, reusing as much of it as possible when it's unchanged. It's also used to complete the output data when some cache resolution fails, to fall back to API data.However, we shouldn't reuse this data blindly when it's API data, since that data can slightly differ and carry
__typename
fields even when those aren't specified in the selection set.Set of changes
originalVariables
with betteroperations.set
trackinginitDataState
cacheExchange
and intead callinitDataState
andclearDataState
manuallyoperations/*