Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use vm.Script for eval #50

Open
rrthomas opened this issue Mar 17, 2024 · 1 comment
Open

Use vm.Script for eval #50

rrthomas opened this issue Mar 17, 2024 · 1 comment

Comments

@rrthomas
Copy link
Collaborator

The obstacle to doing this was that vm.Script does not currently support sourcemaps, so that for backtraces we will have to filter manually. But we need better control of evaluation context, both to have some semblance of security, and in particular to have access to externalSyms so we can properly control access in JavaScript.

@rrthomas rrthomas added this to the 0.3 milestone Mar 17, 2024
@rrthomas
Copy link
Collaborator Author

rrthomas commented Aug 5, 2024

I opened the following issue about this: nodejs/node#52102 and there's an approved PR to fix it that as of this writing needs rebasing.

@rrthomas rrthomas removed this from the 0.3 milestone Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant