condense read_<method>(fua) down to read_results(fua, method)

[jGaboardi]

As per @anastassiavybornova 's suggestion, we might want to condense the following down to something like read_results():

• read_manual()
• read_cityseer()
• read_osmnx
• read_parenx()
• read_neatnet()

Something like:

def read_results(
    fua: int | str, method: str, proj_crs: str | int | pyproj.CRS
) -> geopandas.GeoDataFrame:
    """Read results parquet format.

    Parameters
    -----------
    fua : int | str
        Code or name of FUA.
    method : str
        Simplification method used.
    proj_crs : str | int | pyproj.CRS
        Projected CRS information.

    Returns
    --------
    geopandas.GeoDataFrame
        Simplified results from ``fua`` by ``method``.
    """

    return (
        geopandas.read_parquet(_fua_path(fua, method))
        .explode(ingore_index=True, index_parts=False)
        .to_crs(proj_crs)
    )

read_results('Aleppo', 'manual')
read_results('Aleppo', 'cityseer')
read_results('Aleppo', 'osmnx')
read_results('Aleppo', 'parent-skeleton')
read_results('Aleppo', 'parent-voronoi')
read_results('Aleppo', 'neatnet')

What do yall think?

• yes
• no

cc @martinfleis

[martinfleis]

I don't think it matters. Do whatever you like :)

[jGaboardi]

I don't think it matters. Do whatever you like

You sound like a parent at wit's end. LOL

[anastassiavybornova]

@jGaboardi I think it's a great idea and encourage you to go ahead!

Trying to sound like the other parent but I also really mean it

[martinfleis]

@jGaboardi go ask mom.